i have a recent diff where 300 changes are just things like moving whitespace
still fuck you for that mess
I have vim setup to trim trailing white space, I get so pissed when a small change results in a 300 line diff because of poor code hygiene.
https://github.com/axelf4/vim-strip-trailing-whitespace
There are plugins that will only trim modified lines, which resolves that issue
I had a new dev that was tasked with changing the colors of a button. took them 3 days to do it.
when I finally got the PR there were over 300 files changed and over 100k changes.
they "fixed" the while space. I asked them who asked them to do that. "Nobody, it's just maintenance on the codebase."
I then had an hour long call with them reviewing everywhere they "fixed" the whitespace and got through 10% of it. I asked them if they wanted to have another call tomorrow to review the rest or if they wanted to put the changes forward they were tasked with.
they got the hint and fixed their shit.
rejected
"you're welcome"
Ehh, it really depends. Are most of those files import changes?
I feel attacked!
