The Legends is among us

For your viewing pleasure:

for entry in entries:
    if entry['time'] + 1800 < time():
        guild = self._bot.get_guild(int(entry['guild_id']))
        member = guild.get_member(int(entry['user_id']))
        if member is not None:
            if member.activity.name is not None:
                if member.activity.name.lower() == "league of legends":
                    await member.send("The 30 minutes has elapsed and you are still playing league, get banned.")
                    await member.ban(delete_message_days=0, reason='playing league')

Thats not true!! I used to have fun! At least 4 games in 2000+ over 12 years were definitely fun!!

Arenas was fun because it took the worst parts of league out and is a 2 player team gamemode

Too bad they took it away

Discord has a feature that broadcasts games you play to your friends at all times, and many people leave the feature on.

If the server owner gives the bot access to those permissions and the users have activity sharing enabled, yep.

I worked with chatgpt since I'm not a python dev, and this is what I came up with

from time import time

class PlaySession:
    def __init__(self, data: dict):
        self.guild_id = int(data['guild_id'])
        self.user_id = int(data['user_id'])
        self.timestamp = data['time']

    def is_longer_than_half_hour(self) -> bool:
        return self.timestamp + 1800 < time()

    async def resolve_member(self, bot) -> "discord.Member | None":
        guild = bot.get_guild(self.guild_id)
        return guild.get_member(self.user_id) if guild else None

    @staticmethod
    def is_playing_league(member) -> bool:
        activity = getattr(member, 'activity', None)
        name = getattr(activity, 'name', None)
        return name and name.lower() == "league of legends"

async def ban_for_league(member):
    await member.send("The 30 minutes has elapsed and you are still playing league, get banned.")
    await member.ban(delete_message_days=0, reason="playing league")

async def process_entries(bot, entry_dicts):
    sessions = [PlaySession(d) for d in entry_dicts if PlaySession(d).is_longer_than_half_hour()]
    for session in sessions:
        member = await session.resolve_member(bot)
        if member and PlaySession.is_playing_league(member):
            await ban_for_league(member)

There are two types of programmers.

// comment
if(condition) {
  // comment1
  if(condition1) {
    // comment2
    if(condition2) {
      printf("hello, world\\n");
    }
  }
}

and

// comment
if(!condition) {
  return;
}

// comment1
if(!condition1) {
  return;
}

// comment2
if(!condition2) {
  return;
}

printf("hello, world\\n");

And one is objectively correct.

Not only nested ifs. It's not even correct (doesn't check for activity existing). And it's not even pythonic (ask for forgiveness, not for permission). Just access the thing, catch the exception and be done with it.

Correct me if I'm wrong, but the script works faster with nested IFs since if it fails at the first one, it won't bother reading next ones, unless you kill/return from function.

All in all, this feels like readibility argument, not correctness or efficienty argument

It can but I think it's only client side (for their buggy overlay). Not something bots can access

It seems to match the discord bot api from python and that’d be a more logical choice for a bot lol

GDScript really does read like Python haha

Unless you are using gdscript in a different code editor than godot, it would look different