Mildly Infuriating @lemmy.world Jeena @jemmy.jeena.net 1y ago

I found a nice and easy lemmy bug to fix, but someone beat me to it by 18 hours.

github.com Search only communities by default when coming from communities page · LemmyNet/lemmy-ui@92f6fe9

The official web app for lemmy. Contribute to LemmyNet/lemmy-ui development by creating an account on GitHub.

I already forked the ui-repo, found the correct file to fix it and even found the place where I should add a query to the search form to search only for communities if you start searching from the communities page.

But then I saw that this change is already done in that file. I double checked the HTML on my instance and there it's broken. I checked the history of the page and see it has been fixed 18 hours before I started looking into it.

All my hard work for nothing.

17 comments

It wasn't for nothing.

Think of the skills you gained and the experience.
- And a chance to post it here!
  
  And all the larma to gain!
It be like that sometimes
At least you got yourself into the contributing mindset. Tackle the next issue!
Hey, if not this one then the next one. Onto the next bug!
Lesson learned, always pull and branch from main.
- Actually I was working on the main and that's where I saw it being fixed :D
I have another bug which is bothering me. When the site settings are set to "Registration Mode": "Close Registration", the Sign Up link still shows up and the route still sends you to the Sign Up form. You can fill in everything there but then will get a infinite spinner.

I wanted to at least remove the link at the top when sign up is closed. But obviously it's not as easy as changing a static HTML as in the other bug.
If it's a nice and easy bug, better just make a bug report out of it.
- It's already fixed, no need for more paper.
That’s why you should always search for or file a bug report before trying to create a fix.
Plenty more bugs to fix, don't give up being a contributor!

My process is:

Check for an issue that describes the bug you're seeing.

If there isn't one, create one.

If you feel like it'll be snapped up because it's a relatively easy fix, comment on the issue saying you'll give it a go.

Fix it!

There is still a chance someone might swoop in and fix it but this lowers the chances and it's good to get into the habit of creating and linking Issues to your PRs.
You can just build a time machine and commit it before the other one. Problem solved.
That type of bug is what is called "low hanging fruit". With lots of active contributors, such bugs will get fixed pretty quickly.
I had this exact thing with Mastodon a few days ago. Couldn't find a way to get the local server's post-ID for a federated post if you had the original URL, so I thought "screw it, I'll do it myself".

Downloaded the source, set up a local instance, added extra space to my server so I could run ElasticSearch, went to the file where I wanted to add my "uri:" search prefix, and I find (to paraphrase)...

Send resolve=true to fetch remote instances and return their local ID

Been there for years.

17 comments