4 out of 5 developers
4 out of 5 developers
12 comments
-
-
Currently going through this at work and yes, I'm the guy in the middle. Feeling something between furious anger, maximum frustration, some sadness and worry about my future. Not in IT though.
-
I went through this at my last job. I am a firm advocate of good comments in code, and my work was being reviewed by a guy 25 years younger than me who was a firm advocate of the idea that comments in code are not only undesirable but also an actual "code smell" - evidence of the professional incompetence of the developer that put them there.
I'm a school bus driver now.
-
What code is doing should generally (exceptions are always possible) be evident from the code itself, through clear naming, concise functions with singular goals and proper code structure.
Why code is doing what it does can be helpfully explained through a comment. X may update Y because of business decision Z, so putting a little bit of background info on Z can be very helpful for a future maintainer who might understand what X is doing but might not know why it's doing so in the first place.
If your code requires a lot of comments to make sense, the comments certainly can be a code smell.
-
Shit. I could translate that into my area of expertise. And simply being older than the rest.
And yes, I got fired. Not sure yet what I'm going to do next. This area feels poisoned now.
-
-
-
I am on a new team learning a new language and new frameworks, I can use all of the code review I can get. I need feed back, before I put a bunch of garbage into the code base. Code review is needed for new team members.
-
I'm the middle guy, but I'm a masochist, so:
-
The lead on my team is very much a LGTM reviewer. The project has been going on for 6-7 years.
12 comments