At the moment I use my 8bitdo pro2. It was kinda expensive but its a huge upgrade from my no name switch controllers and awful gamesube one from powera.
Also, the 3ds had really good controls (we don't talk about the c stick)
My favourite controllers are still the official Xbox controllers because of Xbox Design Labs. I like to have my controller look the way I want. And also they seem to be the only controllers that can still be powered by 2 plain rechargable AA batteries.
I always thought the GameCube controller was ridiculously comfortable and ergonomic, so that's my choice. The C stick might not be for everyone though.
Any Dreamcast fans here? Those controllers had similar ergonomics in the hand, although the lack of a second analog stick was a pretty big drawback in hindsight.
DualSense is the best right now IMO due to the features. If you don't believe me, actually play Astro's Playroom.
But I love the Steam Deck's layout (so I guess I'd probably like the Steam Controller as well). A lot of that has to do with Steam Input being fucking awesome, but it's also possible to get relatively good at using the touchpads as mouse, and the "touch right stick to enable gyro" is an awesome feature that has made FPS games playable on console for me.
The 8Bitdo Pro+ has been great - works really well with my Steam Deck and Switch. Sounds like the Pro 2 is the superior version with hall effect sticks.
The Switch Pro controller has always been good too. And the DualSense is really neat with the haptics and adaptive triggers - expensive, but not that much more than a Pro controller surprisingly.
Steam Controller is of course an unbeatable classic, almost it's own category with the weird but charming touchpads.
Of the more conventional controllers I'm a big fan of my current Gulikit KK3 Max. I was looking for a controller with Hall-effect joysticks, and this one looked like one of quality, so I decided why not eh. Feels like a good controller when I use it, so I'm content with it.
It's big enough for my long hands. And it has a ton of features and customizability.
What I don't like is the right track pad when games expect a joystick. Depending on the game controls, it can be suboptimal. (configurable to a degree with center deadzone)
8bitdo ultimate. Already lasted more than a couple of months, as opposed to the last two Xbox controllers I had. I just wanted hall effect joysticks and Xbox layout.
I really liked the wavebird for the gamecube, unfortunately mine went into the aether on my last move, got bluetooth adapters to pair modern controllers with it but the wavebird was really cool at the time, was really amazing to not have to be tethered to the console and it being first party, though at the time the madcatz stuff was decent.
For recent controllers, I've been using a knockoff 360 controller for moonlight recently and after a lot of back and forth I really think MS nailed the controller setup back then (OG Xbox being decent but not a preference, I hated the duke, s controller was solid though), I like the xbone controllers as well, but IMO they're just iterations on the 360 controller, easily my preference as an all rounder controller layout.
I have a steam controller, used it for a while but it's been some time now, had some really great ideas, I'd totally go for an updated steamdeck style layout on that, probably a second for me.
I've had so much drift issues with ds4s that I personally don't reach for a ds4 or dualsense for non playstation games, I like being able to swap batteries and the Xbox/Steam controllers all seem to have way better battery life in general, I keep a stock of rechargeables around so not generating piles of waste.
I'm still using an old PS4 Dual Shock, as I prefer its ergonomics to the Microsoft one... But I have to say the rechargeable AA's of Microsoft are a big plus.
PC game for decades with a recent (5 years?) Switch purchase. I was never a fan of controllers and still aren't for anything to do with aiming, but the Switch Pro Controller impressed me as a real nice piece of hardware. Battery life is phenomenal too.
Also using 8bitdo Pro 2, I like it. Bluetooth connection is somewhat crusty -- for some reason, games think that I'm holding LT, despite me not pressing it. Maybe it's a Linux Mint thing, I dunno. Works perfectly wired, though
PS5 controller. Bought a broken one to fix and replace my xBox 360 controller I'd been using and it feels so much better. The trackpad is also useful for games with partial controller support like My Summer Car.
PS3 (that’s the Dualshock iirc?), Steam Controller, and the Wii U Pro Controller (I quite like the two analog sticks at the top). In that order probably.
I'm using a Thrustmaster Eswap X Pro. The joystick and dpad modules are hot swappable and can be put in any orientation you prefer. They sell replacement joystick modules for $20, which is nice because you don't have to replace the whole controller if one gets stick drift.
I hated the Xbox controller when it first came out, probably because my child-sized hands couldn't reach the buttons comfortably. So it was Playstation style for a long time.
Now as an adult I've switched over to the Xbox style (easier to plug and play for Steam gaming) and I like it a lot. It feels a lot more durable than any other controller I can remember using. Though I feel the size and weight of the controller makes it slightly more difficult to use the bumper and trigger buttons compared to PS controllers, it's not a big deal because I'm not playing FPS these days.
I've been enjoying the GameSir G7 for a while. It's wired but I kind of prefer that. My first G7 had a faulty left stick in the first two months. I think it was faulty from the beginning but I just didn't notice it. I sent them a video of the issue and they replaced it outright.
It's a bit smaller than my Xbox elite controller and it feels pretty great. I like the clicky dpad and the two back buttons. Stick tension is nice as well.
I'd like to see trigger stops but they haven't done that yet. I'd also like to have clicky face buttons so I'm considering one of their khaleid controllers. Those are minor nitpicks, though. This controller has been terrific.
Steam Controller is a flawed masterpiece that I wish we had gotten another iteration of.
Also, speaking of the 8bitdo Pro 2 line, the wired Xbox version of the Pro 2 is pretty great. It's similar to the regular Pro 2, but it has analog triggers, uses Xinput, and has Xbox coloring and branding. It's like they took the best parts of Xbox, SNES, and Playstation controllers and mushed them all together.
I recently upgraded my XBox 360 Wireless controller and got the Flydigi Vader 3 Pro. Hall Effect Sensors trigger guard. Picked it up for und er 50 bucks on Aliexpress. They are available on Amazon US, but not in Europe.