Edit: so im done with my preliminary research into this codebase.
Our corporate SSO provider is changing, so I've been updating our tools to take advantage of the new badges. I found this in a web application that I started on today. The original developer is long gone, and according to our PaaS, this app has been running for just under 3 years without an update.
There is no CI/CD, blue-green deployment, or back ups. The database is an H2 db with ddl-auto set to create-drop on startup, meaning that this database will delete itself if the app is restaged but thanks to this guys code, it won't populate itself. 🤷
Recovering a database from a backup is often possible but often a pain in the ass, and depending on the application you may not consider it acceptable to lose a day of data
Actually, this code is also used in their side business manufacturing cattle prods, that line must be excluded from the prods or else they may become sentient and form a cattle prod based skynet.
Only thing better is finding commented out code below that which would actually prevent it from running in Prod. Bonus if there's a code comment next to it saying "disabled per email" with no further explanation.
Good Lord, this makes my hands sweaty. Why is your entire prod database leaning on one line of code that's prone to human error? There should be 20 extra accidental steps taken to do something like this.
Heh. That looks like it has decent odds of being a "company ending event" incident, to be specific.
But at least there's lots of comments. And maybe someone already put a safety net in somewhere else and just forgot to update the 20 comments. It could happen.
That would be silly. Why pay for QA staff when we can spend customer good-will instead?
Edit: Sorry, I've worked with this kind of stupid so long, I can hear the logic in my bones. The only target that matters is this upcoming quarterly report. The quarterly report after that happens to future me, and he's never done anything for me.
I don't hate it. The docs are good and it's very opinionated, which I appreciate. Makes it easier to divy up the work into chunks management can digest.