The Xbox 360 controller has great compatibility, ergonomics, and price. I do prefer dualshock controllers for fighting games and 2d platformers, though.
For compatibility, triggers and rumble features: any XInput controller
If you like buttons rather than triggers: Logitech Dual Action Controller (hopefully the model that has the modern design)
I have two PowerA controllers, a Fusion Pro 2 and an Enhanced wired controller. Both are for Xbox. The Fusion is fantastic, highly recommend.
If you are on a budget i highly recommend 8 bitdo and gamesir, both stand out in quality from others in the same price range.
Can vouch for 8bitdo having used several of their controllers. A dear friend had also gifted me one of their fight sticks for Christmas and it's been a pleasure. Hasn't made me any better at fighters, mind you.
I cam echo xbox controller. It is great, quite sturdy and of course plug and play.
If you're in the straits, or far east machinike G6, hall effect sensors are great,has motion sensor cna connect via wire/bluetooth/2.4Ghz. It's and expensive one but worth the price. Check it out. Only downside is it's a Chinese brand through and through.
