I guess it depends what you value. I have a Framework 13, first generation. I run Linux on it and really enjoyed putting it together myself (I ordered the DIY option).
I absolutely love their ports. You swap in the ports you want. I normally run a USB C on either side (so I can charge from either side) plus a USB A on each side (the Framework 13 has two slots each side, I think the 16 might have 3 each side?). But I also have HDMI, Display Port, and micro SD in case I need them. I can hot swap them in.
Their guides are awesome. I broke a screen and was able to order another and replace it myself following their guide. When the time comes (probably in the next year or so) I'm planning on upgrading. A bit like a desktop, since it's been a few years it means replacing the motherboard (what they call the mainboard) and RAM since technology moves on. I"m pretty sure like all laptops the CPU is fixed to the mainboard, but you can upgrade RAM or storage without replacing the whole guts (assuming same slot type). In fact you can buy without some pieces and reuse stuff you have or buy from elsewhere to save some money.
When I eventually do it I'm planning on strapping the old mainboard to the back of my TV as a HTPC (replacing the old dying laptop currently there).
There are plenty of downsides. No touchscreen. I wish the screen was a little brighter, it's not bad but could be better (might be better with later models?). I replaced the hinges with their more resistant ones but the screen still moves if I carry it around with the screen open (not sure if it's still an issue on newer models).
I really value the idea of repairability and upgradeability. When I was younger you could swap a bigger harddrive or RAM into a laptop if you had a screwdriver (and sometimes even without), and repairing other parts was also possible. These days you're more likely to find the whole thing glued together. Framework lets you do your own repairs, and has guides to walk you through every step.
There are probably more downsides, but I do love it and would buy another in a heartbeat. But if there are special things you need then carefully check. For example last I checked they did not have a full size SD card reader module available (though of course you can use a regular external one if you really need to).
I mean, all the dell business laptops I've purchased have a replaceable battery. You just have to unscrew the bottom panel to do it. But no, they don't have a swappable battery.
Best laptop I've had so far, but they're quite expensive for their performance tier. The expectation is that you'd never replace it, so theoretically the cost pays itself off over time, but that would assume that you are able and willing to do that sort of long term maintenance.
Basically, I would only recommend it if you were a tinkerer.
I disagree on the comment about cost disparity. Spec'd equivalently, even the Framework 16 (without GPU) is no more expensive than the smaller ThinkPad X1 Carbon. The more comparative Framework 13 even less so.
The modular ports (and GPU on the 16) are a nice bonus, but I agree that the largest attraction is for the tinkerer.
I think the fact that it is easily upgradable makes it a clear winner on the merits alone.
I did a price comparison three years ago when I was exploring laptops and the price for a Framework was really high. Like it was "cheaper to buy a used laptop every three years for a decade before I break even on a Framework" high.
I'm not knocking it at all and I think it's a great idea. It just the cost is so high, and they don't have the means to produce where the price is at a consumer level.
I like mine a lot but as the other commenter alluded too they're pretty pricey but for the 13inch one I think it's the best laptop on the market at that size at the moment.
I do have the first generation which has a battery drain issue, which has since been fixed.
I always use my hardware for a looong time, but I look forward to only having to replace the main mobo and not the screen or keyboard when I do need an upgrade.
And even when you want to replace your main board, you can take the old one, 3D print or buy this Cooler Master case, and turn it into a relatively powerful server or HTPC or K8s node or whatever.