You're viewing a single thread.
2was good, thanks.4needs a tad more thought imho, returning animpl Tdoes have its place, because it makes changing the return type of the function a non-breaking change.Number 4 is only about not returning
impl Intoand instead just returningT.Hmm, right. I think it still might be warranted in niche cases, but trying to think of such a case made it pretty protracted in my head... maybe when functions can also be called for side effects, and the
intoconversion is costly and the caller might not care about the return value?Such a case would be the single function having a side effect*. This allows the caller to chose when to execute the side effect or to drop the result without executing it.
In my opinion that is fine with
fn_oncebut notintobecause of the implicit contract of these traits.* = I'm counting expensive computation, but not allocation and memcopy as a side effect in this comment.