To be specific, the Xbox One Elite controller. I really liked the Series 2 but it fell apart on me. I never had much issue with the original. I'm a glutton for punishment though, and I'd get another Series 2. I don't mind working on them so it isn't the biggest deal
I really love the Switch Pro controller, but I wish it had analog triggers. I also have love for the GameCube controller. I am at home with the N64 controller, but I can't say it's a favorite
It's probably because I have bias, but I've never cared for any of Sony's offerings. Something about the sticks doesn't feel right with both being at the bottom
My series 1 ended up developing a pretty bad flaw with the input chip and is dead-dead. It also developed a sticky X button right away, which I could repair but went back to not being perfect. The Series 2 has been more reliable, but I also use it less.